Feat/pgo v3 by henderkes · Pull Request #1138 · crazywhalecc/static-php-cli

henderkes · 2026-05-11T07:34:25Z

What does this PR do?

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

If you modified *.php or *.json, run them locally to ensure your changes are valid:
- composer cs-fix
- composer analyse
- composer test
- bin/spc dev:sort-config
If it's an extension or dependency update, please ensure the following:
- Add your test combination to src/globals/test-extensions.php.
- If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

…ywhere

github-actions · 2026-05-12T00:52:59Z

StaticPHP Test Bot

Detected: Extensions: opcache, password_argon2, pgsql, spx | Libraries: bzip2, fastlz, gettext-win, icu, jbig, krb5, liblz4, ncurses, openssl, postgresql, qdbm, unixodbc, watcher | Targets: clang-runtime-bits, curl, php
Active labels: none
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS

henderkes · 2026-05-12T01:24:38Z

(I tested with static-php/packages v3 branch, php 8.5 zig on rpm. Tests with Alpine and gcc are still to finish in a few hours when ci runs.)

henderkes · 2026-05-12T01:26:00Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

crazywhalecc · 2026-05-12T01:50:27Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

…ith different pkg_root_path set

…fined behaviour sanitizer)

henderkes · 2026-05-12T04:27:00Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

Okay, added curl.exe on Windows too. Also figured out the root cause of the BUILD_CC patch minilua crash (zigs undefined behaviour sanitizer tripping up, if you run CC="clang -fsanitize=undefined" it will also fail) which coincidentally also fixed a possible edge case bug. BUILD_CC is also used for gen_ir so by using a different vm type it could have theoretically clashed.

henderkes · 2026-05-12T05:59:38Z

Oh, there's even an issue running the binaries despite no undefined sanitizer that I can't reproduce locally or in docker. Very weird.

crazywhalecc · 2026-05-12T06:01:09Z

Oh, there's even an issue running the binaries despite no undefined sanitizer that I can't reproduce locally or in docker. Very weird.

Yup. I have no idea except using native compiler instead.

henderkes · 2026-05-12T06:36:44Z

Hmm, the iconv fail on windows should be unrelated to my changes.

crazywhalecc · 2026-05-14T05:18:48Z

    {
        // get other things
-        $result = self::execWithResult("pkg-config --static --cflags-only-other {$pkg_config_str}");
+        $result = self::execWithResult("pkg-config --static --cflags {$pkg_config_str}");


Do we really need --cflags here? Output may be redundant.

Imagemagick failed because it was missing -I... paths.

Not sure if this behavior is safe and not tested here, but I'd rather fix ImageMagick than change the entire pkgconfig for a single library.

…rom cgo includes, even if they're updated)

crazywhalecc · 2026-05-18T02:42:34Z

    {
        // get other things
-        $result = self::execWithResult("pkg-config --static --cflags-only-other {$pkg_config_str}");
+        $result = self::execWithResult("pkg-config --static --cflags {$pkg_config_str}");


Not sure if this behavior is safe and not tested here, but I'd rather fix ImageMagick than change the entire pkgconfig for a single library.

henderkes · 2026-05-18T03:19:07Z

+    public function fixClangRuntimeBits(): bool
+    {
+        $installer = new PackageInstaller(interactive: false);
+        $installer->addInstallPackage('clang-runtime-bits');


we should probably find a better name for this then 😆

Any better suggestions? 🧐

compiler-rtCrtObjects?

Camel case looks weird here. And zig-compiler-rt ?

it's not full compiler-rt, only the crt start and end objects.

compiler-rt-crt-objects?

We might also add llvm-objcopy because gnu objcopy is too dumb to work on other arch binaries.

Then I think we download full compiler rt anyway, just compiler-rt or llvm-compiler-rt is acceptable.

From compiler-rt we only need the crt objects and the profiling runtime library. llvm-objcopy is from llvm-binutils. Different download.

Or we download full prebuilt llvm-toolchain. It has everything we need but it's a 2gb download instead of 200kb+2 min build time.

Edit: downloading compiler-rt is not a good idea because we'd need to download 2gb per target platform, so at least 2x. For llvm-objcopy we could download, but I feel like 2 minutes of build time are preferable to a 2gb download.

henderkes added 5 commits May 10, 2026 19:27

toolchain fixes forward port from v2-pgo

4f76942

better deduplicate_flags

6e32672

update libraries to honour user flags

efdd2a7

use resolved dependency tree instead of asking for with_suggests ever…

743934d

…ywhere

add pgo capabilities v3 style

7e6e9d8

henderkes force-pushed the feat/pgo-v3 branch from 4f57a12 to 7e6e9d8 Compare May 11, 2026 13:55

henderkes added 2 commits May 11, 2026 21:05

Merge remote-tracking branch 'origin/v3' into feat/pgo-v3

bfaa7eb

reset registry

a585359

henderkes marked this pull request as ready for review May 11, 2026 14:49

henderkes requested a review from crazywhalecc May 11, 2026 14:49

crazywhalecc added the need-test This PR has not been tested yet, cannot merge now label May 12, 2026

henderkes added 7 commits May 12, 2026 09:54

use {pkg_root_path} for packages, otherwise containers get confused w…

4172508

…ith different pkg_root_path set

cant reset it because of the same reason x(

270e2d6

trust filesystem, not downloads

c1c34d8

fix BUILD_CC=cc workaround root cause (minijit trips zig default unde…

8453f69

…fined behaviour sanitizer)

fix phpunit failure

57ef042

wrong exception type

defd50f

array

814014e

henderkes force-pushed the feat/pgo-v3 branch from b5d6e3c to 814014e Compare May 12, 2026 04:20

henderkes added 2 commits May 12, 2026 11:22

we don't need this anymore

2415b7d

also build curl exe on windows

4754faf

henderkes added 3 commits May 12, 2026 11:30

don't add fno-sanitize=undefined for library builds

445c0b3

oops

9addbe2

allow * stage to subscribe to everything

b880ef7

strange shit

db794bf

crazywhalecc reviewed May 14, 2026

View reviewed changes

henderkes added 6 commits May 15, 2026 11:05

drop ldflags fron watcher-c

09de4c9

--build-frankenphp didn't actually build frankenphp

6fda358

clean cgo cache before rebuilding frankenphp (reports wrong version f…

a88e426

…rom cgo includes, even if they're updated)

fix version reevaluating regression from v2

70e717a

don't extract local sources

1707d21

forward port #1138

4b19f4e

henderkes added a commit that referenced this pull request May 16, 2026

forward port #1138

fd882ce

henderkes added 2 commits May 16, 2026 19:16

forward port #1142

07aae79

better cross compile compatibility

19d1379

crazywhalecc reviewed May 18, 2026

View reviewed changes

crazywhalecc added 4 commits May 18, 2026 10:53

Trim base namespace for registry

697040b

Allow vendor mode loading default registry file

fdc75cb

Register artifacts dynamically if not already initialized

ce70c0d

Refactor clang runtime bits support for zig integration

f27ec77

henderkes commented May 18, 2026

View reviewed changes

crazywhalecc added 2 commits May 18, 2026 12:05

Change gettext-win base to 0.18 (master is 1.0 now)

32da708

Whoops

3eca044

Uh oh!

Conversation

henderkes commented May 11, 2026

What does this PR do?

Checklist before merging

Uh oh!

github-actions Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henderkes commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

crazywhalecc commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

crazywhalecc commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazywhalecc May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henderkes May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented May 12, 2026 •

edited

Loading

crazywhalecc May 18, 2026 •

edited

Loading

henderkes May 18, 2026 •

edited

Loading